Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Make SharedArrayBuffer's sole parameter required #2393

Merged
merged 1 commit into from
May 31, 2021

Conversation

syg
Copy link
Contributor

@syg syg commented Apr 26, 2021

SharedArrayBuffer.length is 1 on all web engines (as is
ArrayBuffer.length). Unsure why this was made optional.

eshost output for print(SharedArrayBuffer.length):

#### jsc
1

#### sm
1

#### v8
1

#### xs
1

@syg syg added the needs consensus This needs committee consensus before it can be eligible to be merged. label Apr 26, 2021
@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text web reality labels Apr 26, 2021
@ljharb ljharb requested review from michaelficarra, bakkot and a team April 26, 2021 22:55
spec.html Outdated Show resolved Hide resolved
@ljharb ljharb added has consensus This has committee consensus. and removed needs consensus This needs committee consensus before it can be eligible to be merged. labels May 25, 2021
@syg syg force-pushed the required-sab-param branch from 9d7bbbe to f931795 Compare May 25, 2021 17:57
@jugglinmike
Copy link
Contributor

Test262 already reflects web reality, so no change is required there.

@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label May 29, 2021
SharedArrayBuffer.length is 1 on all web engines (as is
ArrayBuffer.length). Unsure why this was made optional.

eshost output for `print(SharedArrayBuffer.length)`:

```
1

1

1

1
```
@ljharb ljharb force-pushed the required-sab-param branch from f931795 to c2a9389 Compare May 31, 2021 21:20
@ljharb ljharb merged commit c2a9389 into tc39:master May 31, 2021
jugglinmike added a commit to bocoup/proposal-resizablearraybuffer that referenced this pull request Jul 13, 2021
Explicitly specify the value that should be used when optional
parameters are not provided. Update some function signatures to
highlight the modifications included in this proposal. Additionally,
update the signature of the SharedArrayBuffer constructor to reflect a
recent change in ECMA262 [1].

[1] tc39/ecma262#2393
mathiasbynens pushed a commit to mathiasbynens/ecma262 that referenced this pull request Oct 18, 2021
SharedArrayBuffer.length is 1 on all web engines (as is
ArrayBuffer.length). Unsure why this was made optional.

eshost output for `print(SharedArrayBuffer.length)`:

```
1

1

1

1
```
ljharb pushed a commit that referenced this pull request Mar 2, 2022
ljharb pushed a commit that referenced this pull request Mar 2, 2022
ljharb pushed a commit that referenced this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has consensus This has committee consensus. has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text ready to merge Editors believe this PR needs no further reviews, and is ready to land. web reality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants